Add typed data interface to Dart API, this only changes the C++ API as dicussed in a previous email…

Add typed data interface to Dart API, this only changes the C++ API as dicussed in a previous email. The dart code in the library has not been changed yet.
Committed: https://code.google.com/p/dart/source/detail?r=18846

[Anton Muhin, 2013-02-14 12:53:05]

Let's coordinate on landing

https://chromiumcodereview.appspot.com/12255018/diff/18001/include/dart_api.h
File include/dart_api.h (right):

https://chromiumcodereview.appspot.com/12255018/diff/18001/include/dart_api.h...
include/dart_api.h:1658: DART_EXPORT Dart_TypedData_Type
Dart_IsTypedData(Dart_Handle object);
It's somewhat weird to have a method named _Is return anything different from
bool (esp. in the case of _IsExternalTypedData below).  Maybe something like
_GetType?  But up to you.

https://chromiumcodereview.appspot.com/12255018/diff/18001/include/dart_api.h...
include/dart_api.h:1695: Dart_TypedData_Type type,
absolutely minor, feel free to disregard, but I'd rather have type as a first
argument: _NewExternalTypedData(type, data, length): data + length conceptually
tied and type kind of rules the rest of semantics and somewhat mirrors generic
methods application.

Again, up to you to decide.

[siva, 2013-02-14 19:45:42]

Yes Anton I will ping you for co-ordinated landing when I am ready to submit
this CL.

https://chromiumcodereview.appspot.com/12255018/diff/18001/include/dart_api.h
File include/dart_api.h (right):

https://chromiumcodereview.appspot.com/12255018/diff/18001/include/dart_api.h...
include/dart_api.h:1658: DART_EXPORT Dart_TypedData_Type
Dart_IsTypedData(Dart_Handle object);
Renamed to Dart_GetTypeOfTypedData and Dart_GetTypeOfExternalTypedData

On 2013/02/14 12:53:05, Anton Muhin wrote:
> It's somewhat weird to have a method named _Is return anything different from
> bool (esp. in the case of _IsExternalTypedData below).  Maybe something like
> _GetType?  But up to you.

https://chromiumcodereview.appspot.com/12255018/diff/18001/include/dart_api.h...
include/dart_api.h:1695: Dart_TypedData_Type type,
Made type the first parameter.

On 2013/02/14 12:53:05, Anton Muhin wrote:
> absolutely minor, feel free to disregard, but I'd rather have type as a first
> argument: _NewExternalTypedData(type, data, length): data + length
conceptually
> tied and type kind of rules the rest of semantics and somewhat mirrors generic
> methods application.
> 
> Again, up to you to decide.

[Tom Ball, 2013-02-14 21:43:31]

lgtm

[siva, 2013-02-19 22:06:38]

Anton, I am ready to land this patch. Let me know when you have time so that we
can co-ordinate and land it together.

[siva, 2013-02-21 18:22:26]

Sync to top of tree.

[siva, 2013-02-21 18:43:52]

Committed patchset #8 manually as r18846 (presubmit successful).