Chromium Code Reviews

Issue 1225483003: Fix packages_file_test on OS X. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix packages_file_test on OS X. OS X symlinks its /tmp directory, so we need to resolve symlinks before we can safely compare paths that might include /tmp. Committed: https://github.com/dart-lang/pub/commit/e05cfca67574acfdbce55a8422c6bc458be93d10

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+24 lines, -17 lines)
M test/descriptor.dart View 1 chunk +4 lines, -1 line 2 comments
M test/descriptor/packages.dart View 3 chunks +20 lines, -16 lines 0 comments

Messages

Total messages: 5 (1 generated)
nweiz
TBR
5 years, 5 months ago (2015-07-07 21:15:20 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as e05cfca67574acfdbce55a8422c6bc458be93d10 (presubmit successful).
5 years, 5 months ago (2015-07-07 21:16:17 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/1225483003/diff/1/test/descriptor.dart File test/descriptor.dart (right): https://codereview.chromium.org/1225483003/diff/1/test/descriptor.dart#newcode196 test/descriptor.dart:196: /// are located on disk. If the strings ...
5 years, 5 months ago (2015-07-08 16:00:39 UTC) #4
nweiz
5 years, 5 months ago (2015-07-09 00:32:01 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1225483003/diff/1/test/descriptor.dart
File test/descriptor.dart (right):

https://codereview.chromium.org/1225483003/diff/1/test/descriptor.dart#newcod...
test/descriptor.dart:196: /// are located on disk. If the strings are sematnic
versions, then the packages
On 2015/07/08 16:00:38, Bob Nystrom wrote:
> "sematnic" -> "semantic".

Done in a separate CL.

Powered by Google App Engine