Issue 1225423002: Add forward-declarations in attempt to fix Mac/Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1225423002: Add forward-declarations in attempt to fix Mac/Windows build. (Closed)

Created:
5 years, 5 months ago by koda

Modified:
5 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add forward-declarations in attempt to fix Mac/Windows build. BUG= Committed: https://github.com/dart-lang/sdk/commit/ff373e01dda346b7a3bb7b619c3b7b072849045f

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	runtime/bin/thread.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	runtime/vm/os_thread.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

Committed patchset #1 (id:1) manually as ff373e01dda346b7a3bb7b619c3b7b072849045f (presubmit successful).

5 years, 5 months ago (2015-07-09 19:53:01 UTC) #3

koda

5 years, 5 months ago (2015-07-09 20:12:16 UTC) #4

Message was sent while issue was closed.

At least the 32-bit mac build is now succeeding.

I believe the issue was with the unqualified "friend Thread" in
bin/thread_<arch>.h, which due to some include file changes suddenly started
resolving to dart::Thread rather than dart::bin::Thread. Adding the forward
declaration eliminates the ambiguity.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages