Issue 12254048: Revert "Reapply "New implementation of {,Linked}Hash{Set,Map}.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12254048: Revert "Reapply "New implementation of {,Linked}Hash{Set,Map}."" (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Reapply "New implementation of {,Linked}Hash{Set,Map}."" Breaks pub, which apparently contains concurrent modifications of a HashMap. Spurious error in: pkg/analyzer-experimental/test/generated/ast_test/test_literal_map Seems to be an error in the analyzer. TBR Committed: https://code.google.com/p/dart/source/detail?r=18569

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+339 lines, -1735 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/source_map_builder.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/collection/collection.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	sdk/lib/collection/collection_sources.gypi	View	1 chunk	+2 lines, -6 lines	0 comments	Download
D	sdk/lib/collection/hash_map.dart	View	1 chunk	+0 lines, -136 lines	0 comments	Download
D	sdk/lib/collection/hash_set.dart	View	1 chunk	+0 lines, -115 lines	0 comments	Download
D	sdk/lib/collection/hash_table.dart	View	1 chunk	+0 lines, -404 lines	0 comments	Download
D	sdk/lib/collection/linked_hash_map.dart	View	1 chunk	+0 lines, -138 lines	0 comments	Download
D	sdk/lib/collection/linked_hash_set.dart	View	1 chunk	+0 lines, -157 lines	0 comments	Download
D	sdk/lib/collection/linked_hash_table.dart	View	1 chunk	+0 lines, -165 lines	0 comments	Download
A +	sdk/lib/collection/map.dart	View	7 chunks	+214 lines, -46 lines	0 comments	Download
A	sdk/lib/collection/set.dart	View	1 chunk	+110 lines, -0 lines	0 comments	Download
M	sdk/lib/core/map.dart	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	tests/corelib/hash_map2_test.dart	View	1 chunk	+0 lines, -289 lines	0 comments	Download
D	tests/corelib/hash_set_test.dart	View	1 chunk	+0 lines, -206 lines	0 comments	Download
M	tests/corelib/map_from_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages