Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1225403008: Bring in latest dart:io WebSocket code. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http_parser@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bring in latest dart:io WebSocket code. This also moves various copies of dart:io code into their own subdirectory. R=kevmoo@google.com Committed: https://github.com/dart-lang/http_parser/commit/f1960fd1dc9fc5ca4d604ab2523fa360ccfefb11

Patch Set 1 #

Patch Set 2 : pubspec + changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -1214 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
D lib/src/bytes_builder.dart View 1 chunk +0 lines, -212 lines 0 comments Download
A + lib/src/copy/bytes_builder.dart View 3 chunks +6 lines, -1 line 0 comments Download
A lib/src/copy/io_sink.dart View 1 chunk +147 lines, -0 lines 0 comments Download
A lib/src/copy/web_socket.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A + lib/src/copy/web_socket_impl.dart View 12 chunks +101 lines, -173 lines 0 comments Download
M lib/src/web_socket.dart View 5 chunks +6 lines, -827 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-15 22:35:28 UTC) #1
kevmoo
lgtm
5 years, 5 months ago (2015-07-15 22:52:42 UTC) #2
nweiz
5 years, 5 months ago (2015-07-15 23:02:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f1960fd1dc9fc5ca4d604ab2523fa360ccfefb11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698