Issue 122533003: Ignore existing ".dart.js" files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122533003: Ignore existing ".dart.js" files. (Closed)

Created:
6 years, 11 months ago by Bob Nystrom

Modified:
6 years, 11 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore existing ".dart.js" files. This avoids the dart2js transformer raising an error when it tries to compile a Dart file to that same path. BUG=https://code.google.com/p/dart/issues/detail?id=14771 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31597

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -17 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback/sources.dart	View	2 chunks	+20 lines, -0 lines	2 comments	Download
A +	sdk/lib/_internal/pub/test/build/ignores_existing_compiled_js_files_test.dart	View	2 chunks	+6 lines, -14 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/does_not_watch_compiled_js_files_test.dart	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/122533003/diff/1/sdk/lib/_internal/pub/lib/src/barback/sources.dart File sdk/lib/_internal/pub/lib/src/barback/sources.dart (right): https://codereview.chromium.org/122533003/diff/1/sdk/lib/_internal/pub/lib/src/barback/sources.dart#newcode60 sdk/lib/_internal/pub/lib/src/barback/sources.dart:60: // files. Refer to issue 15859 here and ...

6 years, 11 months ago (2014-01-06 23:48:22 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r31597 (presubmit successful).

6 years, 11 months ago (2014-01-08 01:31:00 UTC) #3

Bob Nystrom

6 years, 11 months ago (2014-01-08 01:44:17 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/122533003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/sources.dart (right):

https://codereview.chromium.org/122533003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/sources.dart:60: // files.
On 2014/01/06 23:48:22, nweiz wrote:
> Refer to issue 15859 here and below.

Done.

Expand Messages | Collapse Messages