Issue 122533002: Remove LibValidator to allow assets-only pub packages (http://dartbug.com/15810).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122533002: Remove LibValidator to allow assets-only pub packages (http://dartbug.com/15810). (Closed)

Created:
6 years, 11 months ago by Anton Moiseev

Modified:
6 years, 11 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -110 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/validator.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	sdk/lib/_internal/pub/lib/src/validator/lib.dart	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/validator/lib_test.dart	View	1 chunk	+0 lines, -62 lines	0 comments	Download

Total messages: 4 (0 generated)

Bob Nystrom

This patch LGTM, but I'd like to wait until Nathan gets back from vacation to ...

6 years, 11 months ago (2013-12-30 21:12:05 UTC) #1

Bob Nystrom

Committed patchset #1 manually as r31572 (presubmit successful).

6 years, 11 months ago (2014-01-07 20:51:49 UTC) #3

Bob Nystrom

6 years, 11 months ago (2014-01-07 20:52:18 UTC) #4

Message was sent while issue was closed.

On 2014/01/07 20:51:49, Bob Nystrom wrote:
> Committed patchset #1 manually as r31572 (presubmit successful).

This is in now. Thanks, Anton!

- bob