Issue 12253054: Get rid of join() and encapsulate File and Directory in io.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12253054: Get rid of join() and encapsulate File and Directory in io.dart. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom

Modified:
7 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Get rid of join() and encapsulate File and Directory in io.dart. Committed: https://code.google.com/p/dart/source/detail?r=18551

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -286 lines)			Patch
M	utils/pub/command_lish.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/entrypoint.dart	View		7 chunks	+11 lines, -11 lines	0 comments	Download
M	utils/pub/git_source.dart	View	1	4 chunks	+6 lines, -3 lines	0 comments	Download
M	utils/pub/hosted_source.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	utils/pub/io.dart	View	1	20 chunks	+90 lines, -150 lines	0 comments	Download
M	utils/pub/oauth2.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/pub.dart	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	utils/pub/sdk.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	utils/pub/sdk_source.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	utils/pub/source.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/pub/system_cache.dart	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	utils/pub/validator/compiled_dartdoc.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	utils/pub/validator/lib.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/validator/name.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/io_test.dart	View		2 chunks	+64 lines, -62 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1	14 chunks	+25 lines, -27 lines	0 comments	Download
M	utils/tests/pub/validator_test.dart	View	1	5 chunks	+13 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

Bob Nystrom

We're now using string file paths and pkg/path everywhere. Woo!

7 years, 10 months ago (2013-02-15 01:05:08 UTC) #1

lgtm