Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1225273002: Remove flag for enabling null-aware operators. They are now on by default. (Closed)

Created:
5 years, 5 months ago by sigurdm
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove flag for enabling null-aware operators. They are now on by default. This solves #23791 R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/5d2b0b07f56c81c0f7c328ab1d36501cb0223f36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -77 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/array_based_scanner.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/scanner/listener.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner.dart View 4 chunks +6 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner_task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/scanner/string_scanner.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/scanner/token.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/scanner/utf8_bytes_scanner.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/nullaware_opt_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sigurdm
5 years, 5 months ago (2015-07-09 11:32:33 UTC) #2
Johnni Winther
lgtm
5 years, 5 months ago (2015-07-09 11:46:03 UTC) #3
sigurdm
Committed patchset #1 (id:1) manually as 5d2b0b07f56c81c0f7c328ab1d36501cb0223f36 (presubmit successful).
5 years, 5 months ago (2015-07-09 11:49:57 UTC) #4
Siggi Cherem (dart-lang)
lgtm - Thanks! funny thing I had started this change yesterday as well. I was ...
5 years, 5 months ago (2015-07-09 19:48:34 UTC) #6
sigurdm
5 years, 5 months ago (2015-07-10 07:25:41 UTC) #7
Message was sent while issue was closed.
No I didn't plan on looking into that.

Powered by Google App Engine
This is Rietveld 408576698