Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 12252006: dart:io: Use PathBuffer class for Directory.list on Windows platform. (Closed)

Created:
7 years, 10 months ago by Bill Hesse
Modified:
7 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io: Use PathBuffer class for Directory.list on Windows platform. BUG=https://code.google.com/p/dart/issues/detail?id=7505 Committed: https://code.google.com/p/dart/source/detail?r=18448

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -137 lines) Patch
M runtime/bin/directory_win.cc View 9 chunks +118 lines, -136 lines 1 comment Download
M utils/tests/pub/pub.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
https://codereview.chromium.org/12252006/diff/1/runtime/bin/directory_win.cc File runtime/bin/directory_win.cc (right): https://codereview.chromium.org/12252006/diff/1/runtime/bin/directory_win.cc#newcode69 runtime/bin/directory_win.cc:69: return ok && (!recursive || ListRecursively(path->data, recursive, listing)); Line ...
7 years, 10 months ago (2013-02-13 14:41:40 UTC) #1
Florian Schneider
7 years, 10 months ago (2013-02-13 14:58:33 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698