Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1225103005: Remove incorrect ASSERT (profiler thread needs to walk stack). (Closed)

Created:
5 years, 5 months ago by koda
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove incorrect ASSERT (profiler thread needs to walk stack). BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f2f9c3556bed48c3eccad90bf13be0f21b132fa2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/isolate.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 5 months ago (2015-07-09 20:45:30 UTC) #2
Cutch
lgtm
5 years, 5 months ago (2015-07-09 20:49:04 UTC) #3
koda
5 years, 5 months ago (2015-07-09 20:50:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2f9c3556bed48c3eccad90bf13be0f21b132fa2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698