Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1225083004: dart2js: Emit static const fields if accessible by reflections. (Closed)

Created:
5 years, 5 months ago by herhut
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 1 chunk +15 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A + tests/lib/mirrors/static_const_field_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
5 years, 5 months ago (2015-07-09 09:05:37 UTC) #1
floitsch
LGTM.
5 years, 5 months ago (2015-07-09 09:49:33 UTC) #2
herhut
5 years, 5 months ago (2015-07-09 11:28:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0799e538c38d252590cfd4b5271c203d5b7daa55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698