Issue 122483003: Make "pub help" show global help.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122483003: Make "pub help" show global help. (Closed)

Created:
6 years, 11 months ago by Bob Nystrom

Modified:
6 years, 11 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make "pub help" show global help. BUG=https://code.google.com/p/dart/issues/detail?id=15734 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31566

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -78 lines)			Patch
M	sdk/lib/_internal/pub/bin/pub.dart	View	5 chunks	+3 lines, -76 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command.dart	View	3 chunks	+67 lines, -1 line	2 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/help.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/pub_test.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Also cleaned up the global help code a bit. It was hilariously old-fashioned. It hadn't ...

6 years, 11 months ago (2013-12-30 19:41:25 UTC) #1

nweiz

lgtm https://codereview.chromium.org/122483003/diff/1/sdk/lib/_internal/pub/lib/src/command.dart File sdk/lib/_internal/pub/lib/src/command.dart (right): https://codereview.chromium.org/122483003/diff/1/sdk/lib/_internal/pub/lib/src/command.dart#newcode50 sdk/lib/_internal/pub/lib/src/command.dart:50: buffer.writeln('${pubArgParser.getUsage()}'); '${}' is unnecessary here.

6 years, 11 months ago (2014-01-06 23:43:20 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r31566 (presubmit successful).

6 years, 11 months ago (2014-01-07 19:36:19 UTC) #3

Bob Nystrom

6 years, 11 months ago (2014-01-07 19:37:05 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/122483003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command.dart (right):

https://codereview.chromium.org/122483003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command.dart:50:
buffer.writeln('${pubArgParser.getUsage()}');
On 2014/01/06 23:43:20, nweiz wrote:
> '${}' is unnecessary here.

Done.

Expand Messages | Collapse Messages