Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1224753002: Remove ClassWorld.subclassesOf and ClassWorld.subtypesOf. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove ClassWorld.subclassesOf and ClassWorld.subtypesOf. Closes #23664 BUG= R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/06514d157395fb6999e9e4b9a5392e6791c21146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -67 lines) Patch
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 5 chunks +7 lines, -43 lines 0 comments Download
A tests/compiler/dart2js/world_test.dart View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-06 14:03:32 UTC) #2
herhut
lgtm
5 years, 5 months ago (2015-07-07 09:42:35 UTC) #3
Johnni Winther
5 years, 5 months ago (2015-07-09 08:51:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06514d157395fb6999e9e4b9a5392e6791c21146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698