Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1224693014: Fix for URI resolution w/ file scheme set in package map. (Closed)

Created:
5 years, 5 months ago by pquitslund
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
This properly handles the case where the file scheme is specified in the URI in ...
5 years, 5 months ago (2015-07-08 05:03:35 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-08 13:18:53 UTC) #3
pquitslund
5 years, 5 months ago (2015-07-08 16:18:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81f8d4fa54ea80c154488d45ca6b7461449102d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698