dart2js: Move functionThatReturnsNull to Isolate.

dart2js: Move functionThatReturnsNull to Isolate.

BUG=
R=karlklose@google.com
TBR=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/84e6d695ab9ced79b83f6e19a6ea751ca83a5e7a

Reverted: https://github.com/dart-lang/sdk/commit/3570e3199e129eca1435b6a0924d817e4682883a

Committed: https://github.com/dart-lang/sdk/commit/ff442643fc3a83eff8f6adba29c53f9c1bf4a087

[herhut, 2015-07-06 14:24:37]

Another naming conflict unearthed by the frequency based namer.

[herhut, 2015-07-06 14:24:58]

Committed patchset #1 (id:1) manually as
84e6d695ab9ced79b83f6e19a6ea751ca83a5e7a (presubmit successful).

[sra1, 2015-07-06 14:53:21]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-07-06 14:53:22]

Quick question - why?
I'd like more things to be simple references rather than indirect.

[herhut, 2015-07-06 15:01:33]

On 2015/07/06 14:53:22, sra1 wrote:
> Quick question - why?
> I'd like more things to be simple references rather than indirect.

Because our namer has no concept of the global scope outside of some holder. All
names that come from the namer are only unique within a holder. They collide
with local variable names and the holders themselves. This was always the case
but before we used frequency based naming, we were just lucky enough to get two
letter names for these in most cases.

I had to revert though. So this needs a better fix.

[herhut, 2015-07-07 08:20:54]

herhut@google.com changed reviewers:
+ karlklose@google.com

[herhut, 2015-07-07 08:21:04]

PTAL

[karlklose, 2015-07-07 08:23:52]

LGTM.

[herhut, 2015-07-07 08:25:51]

Committed patchset #2 (id:20001) manually as
ff442643fc3a83eff8f6adba29c53f9c1bf4a087 (presubmit successful).