Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224643003: Don't expect 0.gcd(0) to throw in bigint test. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't expect 0.gcd(0) to throw in bigint test. Committed: https://github.com/dart-lang/sdk/commit/469d541f3198e88e45f04ae4fd30212dbffe9c55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tests/corelib/big_integer_arith_vm_test.dart View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
TBR
5 years, 5 months ago (2015-07-07 09:11:39 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 469d541f3198e88e45f04ae4fd30212dbffe9c55 (presubmit successful).
5 years, 5 months ago (2015-07-07 09:11:47 UTC) #3
Søren Gjesse
5 years, 5 months ago (2015-07-07 09:56:04 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698