Issue 1224603002: dart2js: Use separate namespace for constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1224603002: dart2js: Use separate namespace for constants. (Closed)

Created:
5 years, 5 months ago by herhut

Modified:
5 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Use separate namespace for constants. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/c6eb91b4382c9d1362999d95a6072d56245f4d1b

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/namer.dart	View		4 chunks	+14 lines, -6 lines	0 comments	Download
	M	pkg/js_ast/test/printer_callback_test.dart	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

herhut

https://codereview.chromium.org/1224603002/diff/1/pkg/js_ast/test/printer_callback_test.dart File pkg/js_ast/test/printer_callback_test.dart (right): https://codereview.chromium.org/1224603002/diff/1/pkg/js_ast/test/printer_callback_test.dart#newcode174 pkg/js_ast/test/printer_callback_test.dart:174: String get key => name; This is an merging ...

5 years, 5 months ago (2015-07-03 11:30:08 UTC) #2

herhut

5 years, 5 months ago (2015-07-06 13:00:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c6eb91b4382c9d1362999d95a6072d56245f4d1b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages