Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1224513003: Fix multiline problem in printer_callback_test. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, sra1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix multiline problem in printer_callback_test. BUG= R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/4ed63b679020c953213c7fc078732977d50cea40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/js_ast/test/printer_callback_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-02 11:15:33 UTC) #2
herhut
sra@ also had a similar fix in https://codereview.chromium.org/1213783004/ but as you have changes the test ...
5 years, 5 months ago (2015-07-02 11:19:24 UTC) #3
Johnni Winther
5 years, 5 months ago (2015-07-02 11:20:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ed63b679020c953213c7fc078732977d50cea40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698