Issue 1224423002: Properly report load errors caused by browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1224423002: Properly report load errors caused by browsers. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Properly report load errors caused by browsers. Previously, all errors were getting reported as part of the first suite loaded in a given browser, and future suites were timing out. Now one error is reported per suite. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/767cb3795d2d6916fef2ebe5a9270797b2eb35cc

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	lib/src/runner/browser/server.dart	View	1	3 chunks	+12 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

nweiz

5 years, 5 months ago (2015-07-09 23:36:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
767cb3795d2d6916fef2ebe5a9270797b2eb35cc (presubmit successful).