Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1224363004: Accept 'null' as document.contentScript. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Accept 'null' as document.contentScript. When running as a content script in a Chrome extension `document.contentScript` is set to `null`. We should take that value instead of trying to compute another one based on script tags (the work-around we have for IE). Since content-scripts are not part of the page, it might be that there aren't even any other scripts and the work-around mechanism simply fails (thus not starting the main function). R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/5cf1f598430b8df180caab747c20ddb8f4b8d559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 5 months ago (2015-07-15 13:03:32 UTC) #2
karlklose
LGTM!
5 years, 5 months ago (2015-07-20 10:42:08 UTC) #3
floitsch
5 years, 5 months ago (2015-07-20 10:54:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5cf1f598430b8df180caab747c20ddb8f4b8d559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698