Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223833008: Package map source factory support [FIXED]. (Closed)

Created:
5 years, 5 months ago by pquitslund
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Package map source factory support [FIXED]. A rework of https://codereview.chromium.org/1206323005/ with better handling of the case where a .packages config file is not specified. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/01af0560bbc971bd19100ebe6d8747cce3d05965

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -8 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 6 chunks +72 lines, -4 lines 3 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 3 chunks +147 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pquitslund
5 years, 5 months ago (2015-07-06 21:52:44 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1223833008/diff/1/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (right): https://codereview.chromium.org/1223833008/diff/1/pkg/analyzer/lib/src/generated/source.dart#newcode790 pkg/analyzer/lib/src/generated/source.dart:790: packageUri = Uri.parse( If there are multiple matches, ...
5 years, 5 months ago (2015-07-06 22:17:48 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1223833008/diff/1/pkg/analyzer/lib/src/generated/source.dart File pkg/analyzer/lib/src/generated/source.dart (right): https://codereview.chromium.org/1223833008/diff/1/pkg/analyzer/lib/src/generated/source.dart#newcode790 pkg/analyzer/lib/src/generated/source.dart:790: packageUri = Uri.parse( On 2015/07/06 22:17:48, Brian Wilkerson ...
5 years, 5 months ago (2015-07-07 16:10:24 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as 01af0560bbc971bd19100ebe6d8747cce3d05965 (presubmit successful).
5 years, 5 months ago (2015-07-07 16:10:57 UTC) #5
Brian Wilkerson
5 years, 5 months ago (2015-07-07 16:18:03 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1223833008/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/1223833008/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/source.dart:790: packageUri = Uri.parse(
Yes, I missed that.

Powered by Google App Engine
This is Rietveld 408576698