Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1223293002: dart2js: Rename old emitter to full emitter and make it its own library. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Rename old emitter to full emitter and make it its own library. R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/cf4eca09750815c2f9a87ebba6ff60d5841f25df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -110 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/code_emitter_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/declarations.dart View 2 chunks +1 line, -7 lines 0 comments Download
A + pkg/compiler/lib/src/js_emitter/full_emitter/deferred_output_unit_hash.dart View 2 chunks +2 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +88 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/helpers.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 6 chunks +2 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/dart2js_incremental.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 5 chunks +7 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 2 chunks +4 lines, -1 line 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 5 months ago (2015-07-09 12:01:25 UTC) #2
herhut
lgtm
5 years, 5 months ago (2015-07-09 13:33:57 UTC) #3
floitsch
5 years, 5 months ago (2015-07-09 13:54:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cf4eca09750815c2f9a87ebba6ff60d5841f25df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698