Issue 12230033: Adding supported checks and flags to FormData

Issue 12230033: Adding supported checks and flags to FormData (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding supported checks and flags to FormData Also fixing the test to pass on IE10. BUG=4793 Committed: https://code.google.com/p/dart/source/detail?r=18554

Patch Set 3 : Fixing up XHR test as well. #

Total comments: 2

Patch Set 4 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -53 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		6 chunks	+35 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		6 chunks	+33 lines, -0 lines	0 comments	Download
M	tests/html/form_data_test.dart	View	1	2 chunks	+64 lines, -44 lines	0 comments	Download
M	tests/html/html.status	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/xhr_test.dart	View	1 2 3	5 chunks	+24 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate	View	1 2 3	1 chunk	+24 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/12230033/diff/6001/tests/html/xhr_test.dart File tests/html/xhr_test.dart (right): https://codereview.chromium.org/12230033/diff/6001/tests/html/xhr_test.dart#newcode42 tests/html/xhr_test.dart:42: test('XHR.request onProgress', () { this doesn't actually perform a ...

7 years, 10 months ago (2013-02-14 21:56:23 UTC) #2

blois

7 years, 10 months ago (2013-02-14 23:22:45 UTC) #3

Emily Fortuna

https://codereview.chromium.org/12230033/diff/8/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right): https://codereview.chromium.org/12230033/diff/8/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate#newcode140 tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate:140: static bool get supportsLoadEndEvent { can these be added ...

7 years, 10 months ago (2013-02-14 23:51:41 UTC) #4

blois

On 2013/02/14 23:51:41, Emily Fortuna wrote: > https://codereview.chromium.org/12230033/diff/8/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate > File tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate (right): > > https://codereview.chromium.org/12230033/diff/8/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate#newcode140 ...

7 years, 10 months ago (2013-02-14 23:54:15 UTC) #5

right.
lgtm!

Expand Messages | Collapse Messages