Issue 1222913009: dart2js cps: Bugfix in redundant phi elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222913009: dart2js cps: Bugfix in redundant phi elimination. (Closed)

Created:
5 years, 5 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Bugfix in redundant phi elimination. We now split a LetCont before moving it, so we do not move other continuation bindings. The bug surfaced when working on redundant join elimination. I don't think it can be reproduced with the current set of optimizations, so the fix is not visible in the tests. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/6698031d9b469fdb0fa18a0a60700645d3523971

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/cps_ir/redundant_phi.dart	View		2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 5 months ago (2015-07-08 12:46:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6698031d9b469fdb0fa18a0a60700645d3523971 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages