Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1222913003: dart2js cps: Support JS_CURRENT_ISOLATE. (Closed)

Created:
5 years, 5 months ago by karlklose
Modified:
5 years, 5 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Status files rebased before change. #

Patch Set 3 : Status file changes after change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+716 lines, -743 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +43 lines, -44 lines 0 comments Download
M samples/samples.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 7 chunks +222 lines, -227 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 1 chunk +18 lines, -27 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +6 lines, -8 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +22 lines, -24 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 5 chunks +75 lines, -79 lines 0 comments Download
M tests/lib/lib.status View 1 2 4 chunks +308 lines, -315 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/utils/utils.status View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
karlklose
Patch set 1 is the change. The diff between Patchset 2 and 3 shows the ...
5 years, 5 months ago (2015-07-07 12:44:06 UTC) #2
asgerf
LGTM.
5 years, 5 months ago (2015-07-07 12:47:55 UTC) #3
karlklose
5 years, 5 months ago (2015-07-07 13:55:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
71e2bec0a51d20c6d8c26adcce427e454b19dd5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698