Issue 1222763003: dart2js cps: Do not rewrite calls on torn-off intercepted methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222763003: dart2js cps: Do not rewrite calls on torn-off intercepted methods. (Closed)

Created:
5 years, 5 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Do not rewrite calls on torn-off intercepted methods. For example: getInterceptor(foo).get$toString(foo).call$0() Should be rewritten to: getInterceptor(foo).toString$0(foo) But would erroneously be rewritten to: getInterceptor(foo).toString$0() BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/535ed4042ff03f96831105633820d7ed00b22aab

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 5 months ago (2015-07-06 11:08:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
535ed4042ff03f96831105633820d7ed00b22aab (presubmit successful).