Issue 12226134: Fixing Indexed DB's CursorWithValue.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226134: Fixing Indexed DB's CursorWithValue.value (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing Indexed DB's CursorWithValue.value CursorWithValue.value was not getting converted from a JS type to a Dart type. BUG=8254 Committed: https://code.google.com/p/dart/source/detail?r=18476

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -10 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/indexeddb_2_test.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://codereview.chromium.org/12226134/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12226134/diff/1/tools/dom/scripts/generator.py#newcode479 tools/dom/scripts/generator.py:479: '* get IDBCursorWithValue.value': Perhaps this map should be ...

7 years, 10 months ago (2013-02-13 18:41:42 UTC) #2

blois

7 years, 10 months ago (2013-02-13 20:43:17 UTC) #3

On 2013/02/13 18:41:42, sra1 wrote:
> lgtm
> 
> https://codereview.chromium.org/12226134/diff/1/tools/dom/scripts/generator.py
> File tools/dom/scripts/generator.py (right):
> 
>
https://codereview.chromium.org/12226134/diff/1/tools/dom/scripts/generator.p...
> tools/dom/scripts/generator.py:479: '* get IDBCursorWithValue.value':
> Perhaps this map should be monitored.

Addressing the monitoring as a separate CL. There are a number of unmonitored
collections which should be monitored and a number of errors which get
uncovered.

Expand Messages | Collapse Messages