Updating Element.scrollIntoView to be platform independent.

Updating Element.scrollIntoView to be platform independent.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18498

[Jacob, 2013-02-12 23:12:33]

https://codereview.chromium.org/12226129/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/12226129/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_Element.darttemplate:789: void
scrollIntoView({bool alignCenter, bool alignTop, bool alignBottom}) {
shouldn't this be an enum instead of 3 bools?

[blois, 2013-02-13 01:37:42]

Now with enums.

One note is that this still prefers scrollIntoViewIfNeeded over scrollIntoView,
when available, implying that no args means best-effort and
scrollIntoVeiwIfNeeded is best effort.

[blois, 2013-02-13 20:57:01]

On 2013/02/13 01:37:42, blois wrote:
> Now with enums.
> 
> One note is that this still prefers scrollIntoViewIfNeeded over
scrollIntoView,
> when available, implying that no args means best-effort and
> scrollIntoVeiwIfNeeded is best effort.

Added docs to enum, ptal.

[Jacob, 2013-02-13 21:08:19]

https://codereview.chromium.org/12226129/diff/8001/sdk/lib/html/dartium/html_...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/12226129/diff/8001/sdk/lib/html/dartium/html_...
sdk/lib/html/dartium/html_dartium.dart:9747: +  void
scrollIntoView([ScrollIntoViewAlignment alignment]) {
Why not call ScrollIntoViewAlignment
just
Anchor 
or 
Alignment?

I think Anchor would align with similar CSS concepts that are in progress.

[blois, 2013-02-13 21:14:22]

On 2013/02/13 21:08:19, Jacob wrote:
>
https://codereview.chromium.org/12226129/diff/8001/sdk/lib/html/dartium/html_...
> File sdk/lib/html/dartium/html_dartium.dart (right):
> 
>
https://codereview.chromium.org/12226129/diff/8001/sdk/lib/html/dartium/html_...
> sdk/lib/html/dartium/html_dartium.dart:9747: +  void
> scrollIntoView([ScrollIntoViewAlignment alignment]) {
> Why not call ScrollIntoViewAlignment
> just
> Anchor 
> or 
> Alignment?
> 
> I think Anchor would align with similar CSS concepts that are in progress.

I'm worried about name conflicts- this is in dart:html root. It also seems to be
specific to this method, and if we reuse it later then it will be odd if we add
additional cases (left, right, etc).

[Jacob, 2013-02-13 22:08:14]

The problem is any time a user calls this method they will have to type this 4
word long class names.  Seems like something we want to avoid in Dart. Got a 2
word long class name that you are satisfied with?

lgtm

On 2013/02/13 21:14:22, blois wrote:
> On 2013/02/13 21:08:19, Jacob wrote:
> >
>
https://codereview.chromium.org/12226129/diff/8001/sdk/lib/html/dartium/html_...
> > File sdk/lib/html/dartium/html_dartium.dart (right):
> > 
> >
>
https://codereview.chromium.org/12226129/diff/8001/sdk/lib/html/dartium/html_...
> > sdk/lib/html/dartium/html_dartium.dart:9747: +  void
> > scrollIntoView([ScrollIntoViewAlignment alignment]) {
> > Why not call ScrollIntoViewAlignment
> > just
> > Anchor 
> > or 
> > Alignment?
> > 
> > I think Anchor would align with similar CSS concepts that are in progress.
> 
> I'm worried about name conflicts- this is in dart:html root. It also seems to
be
> specific to this method, and if we reuse it later then it will be odd if we
add
> additional cases (left, right, etc).

[Jacob, 2013-02-13 23:11:30]

ScrollAlignment sounds good.
lgtm