Issue 12226074: Cleanup universe to not have backend related things.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226074: Cleanup universe to not have backend related things. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
Johnni Winther, karlklose

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup universe to not have backend related things. Committed: https://code.google.com/p/dart/source/detail?r=18245

Patch Set 1 : #

Patch Set 2 : #

Total comments: 3

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -117 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		4 chunks	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View		8 chunks	+28 lines, -55 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	5 chunks	+41 lines, -4 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		4 chunks	+12 lines, -11 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View		3 chunks	+14 lines, -40 lines	0 comments	Download
M	tests/compiler/dart2js/compiler_helper.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

7 years, 10 months ago (2013-02-08 11:44:53 UTC) #3

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/12226074/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/12226074/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:625: * The
generated code as a js AST for compiled methods.
'js' -> 'JavaScript' or 'JS'

https://codereview.chromium.org/12226074/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:632: * The
generated code as a js AST for compiled bailout methods.
ditto.

https://codereview.chromium.org/12226074/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/12226074/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:717:
JavaScriptBackend backend = compiler.backend;
How about making this a getter? I count 19 occurrences in this file.

Expand Messages | Collapse Messages