Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 12225151: Refactor idlsync.py to update chrome apps idl/tools. (Closed)

Created:
7 years, 10 months ago by vsm
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org, blois
Visibility:
Public.

Description

Refactor idlsync.py to update chrome apps idl/tools. Note, by default, idlsync.py will only update webkit IDL. Use: idlsync.py -u chrome to update chrome only or: idlsync.py -u all to update both. Sasha: can you verify that the WHITELIST (*.py, *.idl, *.json) matches the files you need? Everything else will be pruned. Also, note, I've slightly changed the directories to not conflict with the existing ones pulled in by DEPS. I will remove those existing ones in a separate CL (the DEPS is a slightly different repo path). Emily/Anton: can you review the rest? If this looks good, the intent is to run and check-in the files under third_party/chrome. BUG=http://code.google.com/p/dart/issues/detail?id=8173

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -48 lines) Patch
M tools/dom/scripts/idlsync.py View 1 3 chunks +118 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsm
7 years, 10 months ago (2013-02-12 23:37:55 UTC) #1
Anton Muhin
lgtm with comments addressed https://chromiumcodereview.appspot.com/12225151/diff/1/tools/dom/scripts/idlsync.py File tools/dom/scripts/idlsync.py (right): https://chromiumcodereview.appspot.com/12225151/diff/1/tools/dom/scripts/idlsync.py#newcode18 tools/dom/scripts/idlsync.py:18: DEPS = 'http://dart.googlecode.com/svn/branches/bleeding_edge/deps/dartium.deps/DEPS' nit: maybe ...
7 years, 10 months ago (2013-02-13 07:49:36 UTC) #2
Emily Fortuna
lgtm with anton's comments https://chromiumcodereview.appspot.com/12225151/diff/1/tools/dom/scripts/idlsync.py File tools/dom/scripts/idlsync.py (right): https://chromiumcodereview.appspot.com/12225151/diff/1/tools/dom/scripts/idlsync.py#newcode161 tools/dom/scripts/idlsync.py:161: help='IDL to update (webkit | ...
7 years, 10 months ago (2013-02-13 18:33:42 UTC) #3
vsm
Thanks! Addressed comments and landing. https://codereview.chromium.org/12225151/diff/1/tools/dom/scripts/idlsync.py File tools/dom/scripts/idlsync.py (right): https://codereview.chromium.org/12225151/diff/1/tools/dom/scripts/idlsync.py#newcode18 tools/dom/scripts/idlsync.py:18: DEPS = 'http://dart.googlecode.com/svn/branches/bleeding_edge/deps/dartium.deps/DEPS' On ...
7 years, 10 months ago (2013-02-13 18:53:27 UTC) #4
Anton Muhin
https://codereview.chromium.org/12225151/diff/1/tools/dom/scripts/idlsync.py File tools/dom/scripts/idlsync.py (right): https://codereview.chromium.org/12225151/diff/1/tools/dom/scripts/idlsync.py#newcode178 tools/dom/scripts/idlsync.py:178: if not revision: There is an important difference: not ...
7 years, 10 months ago (2013-02-13 18:59:58 UTC) #5
sashab
7 years, 10 months ago (2013-02-14 00:39:59 UTC) #6
Message was sent while issue was closed.
lgtm, whitelist seems fine :)

Later, you might want to include api.gyp as well, as that contains a nice list
of all the IDL files to include. But that's later down the track.

Powered by Google App Engine
This is Rietveld 408576698