Auto-reinstall broken packages in the system cache.

Auto-reinstall broken packages in the system cache.

BUG=http://code.google.com/p/dart/issues/detail?id=5939

Committed: https://code.google.com/p/dart/source/detail?r=18480

[Bob Nystrom, 2013-02-12 22:58:36]

I only wrote an integration test for the hosted source, but this should work for
any cache source (i.e. git too).

[nweiz, 2013-02-13 00:19:21]

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart
File utils/pub/source.dart (right):

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart#newcode117
utils/pub/source.dart:117: // got borked and reinstall.
What if just "lib" or the contents of "lib" got wiped out? Isn't that an issue
we were seeing, since that's where the symlink points?

https://codereview.chromium.org/12225149/diff/1/utils/tests/pub/install/hoste...
File utils/tests/pub/install/hosted/repair_cache_test.dart (right):

https://codereview.chromium.org/12225149/diff/1/utils/tests/pub/install/hoste...
utils/tests/pub/install/hosted/repair_cache_test.dart:21: });
Why aren't you using the standard directory declaration stuff here?

[Bob Nystrom, 2013-02-13 01:27:11]

Thanks!

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart
File utils/pub/source.dart (right):

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart#newcode117
utils/pub/source.dart:117: // got borked and reinstall.
On 2013/02/13 00:19:21, nweiz wrote:
> What if just "lib" or the contents of "lib" got wiped out? Isn't that an issue
> we were seeing, since that's where the symlink points?

Oh, great call. Duh.

Fixed this to look for an empty lib dir.

https://codereview.chromium.org/12225149/diff/1/utils/tests/pub/install/hoste...
File utils/tests/pub/install/hosted/repair_cache_test.dart (right):

https://codereview.chromium.org/12225149/diff/1/utils/tests/pub/install/hoste...
utils/tests/pub/install/hosted/repair_cache_test.dart:21: });
On 2013/02/13 00:19:21, nweiz wrote:
> Why aren't you using the standard directory declaration stuff here?

The descriptor stuff is designed to represent directory trees where every node
along the path is meaningful. In this case, I just want to do something with the
leaf directory of the path.

Adding "scheduleEnsureDir()" to Descriptor felt weird to me.

[nweiz, 2013-02-13 02:02:05]

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart
File utils/pub/source.dart (right):

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart#newcode117
utils/pub/source.dart:117: // got borked and reinstall.
On 2013/02/13 01:27:11, Bob Nystrom wrote:
> On 2013/02/13 00:19:21, nweiz wrote:
> > What if just "lib" or the contents of "lib" got wiped out? Isn't that an
issue
> > we were seeing, since that's where the symlink points?
> 
> Oh, great call. Duh.
> 
> Fixed this to look for an empty lib dir.

I feel like having the pubspec check as well is still a good idea, in case the
entire directory is erased somehow.

[Bob Nystrom, 2013-02-13 18:00:26]

Should be better now:

1. It manually creates a broken cache using scheduleCreate() instead of
installing and then deleting a piece.
2. Made _schedule() private again.
3. Put the missing pubspec heuristic back in.

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart
File utils/pub/source.dart (right):

https://codereview.chromium.org/12225149/diff/1/utils/pub/source.dart#newcode117
utils/pub/source.dart:117: // got borked and reinstall.
On 2013/02/13 02:02:05, nweiz wrote:
> On 2013/02/13 01:27:11, Bob Nystrom wrote:
> > On 2013/02/13 00:19:21, nweiz wrote:
> > > What if just "lib" or the contents of "lib" got wiped out? Isn't that an
> issue
> > > we were seeing, since that's where the symlink points?
> > 
> > Oh, great call. Duh.
> > 
> > Fixed this to look for an empty lib dir.
> 
> I feel like having the pubspec check as well is still a good idea, in case the
> entire directory is erased somehow.

Done.

[nweiz, 2013-02-13 19:54:31]

lgtm

https://codereview.chromium.org/12225149/diff/9001/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/12225149/diff/9001/utils/tests/pub/test_pub.d...
utils/tests/pub/test_pub.dart:366: // TODO REMOVE
Did you mean to actually remove this method?

[Bob Nystrom, 2013-02-13 21:11:31]

Thanks!

https://codereview.chromium.org/12225149/diff/9001/utils/tests/pub/test_pub.dart
File utils/tests/pub/test_pub.dart (right):

https://codereview.chromium.org/12225149/diff/9001/utils/tests/pub/test_pub.d...
utils/tests/pub/test_pub.dart:366: // TODO REMOVE
On 2013/02/13 19:54:31, nweiz wrote:
> Did you mean to actually remove this method?

Heh, yes. :)