Minor cleanup

Minor cleanup
- added a field parsed_function to the parser
- remove fields expression_temp_ and saved_current_context_
Committed: https://code.google.com/p/dart/source/detail?r=18402

[srdjan, 2013-02-12 19:30:46]

lgtm

[hausner, 2013-02-12 19:34:04]

LGTM w/comment

https://chromiumcodereview.appspot.com/12225141/diff/3001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/12225141/diff/3001/runtime/vm/parser.c...
runtime/vm/parser.cc:305: ASSERT(parsed_function() != NULL);
You make it illegal to call current_function() when parsing top-level.
Previously, Function::null() was returned. I take it we didn't depend on this.

[siva, 2013-02-12 20:47:07]

https://chromiumcodereview.appspot.com/12225141/diff/3001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/12225141/diff/3001/runtime/vm/parser.c...
runtime/vm/parser.cc:305: ASSERT(parsed_function() != NULL);
Initially I implemented this to check if parsed_function is null and return
Function::null(). Then I figured if nobody uses it that way why pay the price
for a check. So I added an assertion that this function does not expect
parsed_function to NULL. If we find cases where we need to access
current_function I can convert the assert to a check.

So far the test suites did not trip the ASSERT.

On 2013/02/12 19:34:04, hausner wrote:
> You make it illegal to call current_function() when parsing top-level.
> Previously, Function::null() was returned. I take it we didn't depend on this.