Issue 12225118: Fix typo and add a regression test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225118: Fix typo and add a regression test. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix typo and add a regression test. Committed: https://code.google.com/p/dart/source/detail?r=18314

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/compiler/dart2js/type_combination_test.dart	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

lgtm https://codereview.chromium.org/12225118/diff/1/tests/compiler/dart2js/type_combination_test.dart File tests/compiler/dart2js/type_combination_test.dart (right): https://codereview.chromium.org/12225118/diff/1/tests/compiler/dart2js/type_combination_test.dart#newcode2040 tests/compiler/dart2js/type_combination_test.dart:2040: void testRegressions(Compiler compiler) { Move before main.

7 years, 10 months ago (2013-02-11 17:33:18 UTC) #2

ngeoffray

7 years, 10 months ago (2013-02-11 17:36:06 UTC) #3

Thanks Peter.

https://codereview.chromium.org/12225118/diff/1/tests/compiler/dart2js/type_c...
File tests/compiler/dart2js/type_combination_test.dart (right):

https://codereview.chromium.org/12225118/diff/1/tests/compiler/dart2js/type_c...
tests/compiler/dart2js/type_combination_test.dart:2040: void
testRegressions(Compiler compiler) {
On 2013/02/11 17:33:18, ahe wrote:
> Move before main.

Done.

Expand Messages | Collapse Messages

Issue 12225118: Fix typo and add a regression test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages