Issue 12225109: Revert "Change the location of the output directory" plus one other fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225109: Revert "Change the location of the output directory" plus one other fix. (Closed)

Created:
7 years, 10 months ago by Emily Fortuna

Modified:
7 years, 10 months ago

Reviewers:
dgrove, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Change the location of the output directory" plus one other fix. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18295

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -131 lines)			Patch
M	tools/test.dart	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/test-runtime.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/testing/dart/browser_test.dart	View	3 chunks	+22 lines, -11 lines	0 comments	Download
M	tools/testing/dart/http_server.dart	View	3 chunks	+1 line, -24 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	7 chunks	+56 lines, -90 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This reverts revision 18176, "Change the location of the output directory of generated tests to ...

7 years, 10 months ago (2013-02-09 01:48:25 UTC) #1

dgrove

7 years, 10 months ago (2013-02-09 04:01:24 UTC) #4

Message was sent while issue was closed.

On 2013/02/09 02:06:47, Siggi Cherem (dart-lang) wrote:
> from high-level look at things, lgtm

LGTM.

Martin, for some more context on this - without this reversion, we were getting
this failure when trying to build trunk:
http://build.chromium.org/p/client.dart/builders/dartium-win-full-trunk/build...

Expand Messages | Collapse Messages