Issue 12225059: fix publish for analyzer-experimental

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225059: fix publish for analyzer-experimental (Closed)

Created:
7 years, 10 months ago by Jennifer Messerly

Modified:
7 years, 10 months ago

Reviewers:
dgrove

CC:
reviews_dartlang.org, pquitslund

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix publish for analyzer-experimental Committed: https://code.google.com/p/dart/source/detail?r=18239

Patch Set 2 : also fix publish_all #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	tools/publish_all_pkgs.py	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
	M	tools/publish_pkg.py	View		4 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

apparently Pub package names can't contain dash https://codereview.chromium.org/12225059/diff/1/tools/publish_pkg.py File tools/publish_pkg.py (right): https://codereview.chromium.org/12225059/diff/1/tools/publish_pkg.py#newcode61 tools/publish_pkg.py:61: pkgName = ...

7 years, 10 months ago (2013-02-06 21:02:38 UTC) #1

Jennifer Messerly

On 2013/02/06 21:04:08, John Messerly wrote: > also fixes publish_all PTAL :)

7 years, 10 months ago (2013-02-06 21:04:14 UTC) #4

lgtm

Expand Messages | Collapse Messages

Issue 12225059: fix publish for analyzer-experimental (Closed)

Description

Patch Set 1 #

Patch Set 2 : also fix publish_all #

Messages