Issue 12225031: Minor cleanup of activation frame creation code. Get the code object while iterating the frames as …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225031: Minor cleanup of activation frame creation code. Get the code object while iterating the frames as … (Closed)

Created:
7 years, 10 months ago by siva

Modified:
7 years, 10 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Minor cleanup of activation frame creation code. Get the code object while iterating the frames as that is way faster than doing a code lookup later. Committed: https://code.google.com/p/dart/source/detail?r=18162

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -47 lines)			Patch
	M	vm/debugger.h	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download
	M	vm/debugger.cc	View	1	12 chunks	+19 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comments https://codereview.chromium.org/12225031/diff/1/vm/debugger.cc File vm/debugger.cc (right): https://codereview.chromium.org/12225031/diff/1/vm/debugger.cc#newcode155 vm/debugger.cc:155: const Code& ActivationFrame::DartCode() { As discussed offline, ...

7 years, 10 months ago (2013-02-06 01:22:15 UTC) #2

siva

7 years, 10 months ago (2013-02-06 01:41:43 UTC) #3

https://codereview.chromium.org/12225031/diff/1/vm/debugger.cc
File vm/debugger.cc (right):

https://codereview.chromium.org/12225031/diff/1/vm/debugger.cc#newcode155
vm/debugger.cc:155: const Code& ActivationFrame::DartCode() {
On 2013/02/06 01:22:15, hausner wrote:
> As discussed offline, this can now be a simple accessor code().

Done.

https://codereview.chromium.org/12225031/diff/1/vm/debugger.cc#newcode161
vm/debugger.cc:161: const Function& ActivationFrame::DartFunction() {
On 2013/02/06 01:22:15, hausner wrote:
> Ditto, turn into function().

Done.

Expand Messages | Collapse Messages