Issue 12224080: Fixes for TransitionEvent changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12224080: Fixes for TransitionEvent changes. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes for TransitionEvent changes. Two changes- Removed the extends clause for _WebKitTransitionEvent which caused an issues with dartc. Platform-independent changes for firing the event broke element_test on non-Chrome browsers. This test is actually quite useless. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18278

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -4 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/element_test.dart	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	tools/dom/templates/html/impl/impl_WebKitTransitionEvent.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/12224080/diff/1/tests/html/element_test.dart File tests/html/element_test.dart (left): https://codereview.chromium.org/12224080/diff/1/tests/html/element_test.dart#oldcode266 tests/html/element_test.dart:266: testEvent(target.onTransitionEnd, 'webkitTransitionEnd'); We should probably just remove all of ...

7 years, 10 months ago (2013-02-08 21:42:23 UTC) #1

ha! lgtm

Expand Messages | Collapse Messages