Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 12223115: SSE Assembler + Linux build fixes (Closed)

Created:
7 years, 10 months ago by Cutch
Modified:
7 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

SSE Assembler + Linux build fixes Committed: https://code.google.com/p/dart/source/detail?r=18493

Patch Set 1 #

Total comments: 1

Patch Set 2 : -msse2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1457 lines, -23 lines) Patch
M runtime/platform/globals.h View 2 chunks +34 lines, -1 line 0 comments Download
M runtime/vm/assembler_ia32.h View 3 chunks +31 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 6 chunks +251 lines, -6 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +372 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 2 chunks +33 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 7 chunks +290 lines, -6 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +324 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 4 chunks +72 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 3 chunks +46 lines, -6 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
7 years, 10 months ago (2013-02-12 23:55:05 UTC) #1
srdjan
https://codereview.chromium.org/12223115/diff/1/tools/gyp/configurations_make.gypi File tools/gyp/configurations_make.gypi (right): https://codereview.chromium.org/12223115/diff/1/tools/gyp/configurations_make.gypi#newcode36 tools/gyp/configurations_make.gypi:36: 'cflags': [ '-m32', '-msse' ], As discussed, change to ...
7 years, 10 months ago (2013-02-13 21:47:29 UTC) #2
Cutch
Patch Set 2 has -msse2. Test suite: ../tools/test.py -a simarm,simmips,ia32,x64 -m all Test configurations: none_vm_debug_simarm ...
7 years, 10 months ago (2013-02-13 22:47:02 UTC) #3
srdjan
7 years, 10 months ago (2013-02-13 22:49:00 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698