Fix for Issue 8460.

Fix for Issue 8460.

Committed: https://code.google.com/p/dart/source/detail?r=18556

[sra1, 2013-02-13 02:48:03]

I welcome any ideas for improving the check.

[ngeoffray, 2013-02-13 08:23:06]

https://codereview.chromium.org/12221162/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/native_helper.dart (right):

https://codereview.chromium.org/12221162/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/native_helper.dart:257: }
Why not put everything below until the apply in the if? AFAICS, the following
only applies to native objects.

https://codereview.chromium.org/12221162/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/native_helper.dart:294: // The
code does 'obj instanceof $.Object'.  It is safer that testing a
How about adding a new JS? JS_DART_OBJECT_PROTOTYPE?

[sra1, 2013-02-15 02:58:17]

https://codereview.chromium.org/12221162/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/lib/native_helper.dart (right):

https://codereview.chromium.org/12221162/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/native_helper.dart:257: }
On 2013/02/13 08:23:06, ngeoffray wrote:
> Why not put everything below until the apply in the if? AFAICS, the following
> only applies to native objects.

Some of the lookups are still needed for type predicates, e.g. $isList =
function(){return false; } must always be found.

This will likely change as we move to using interceptors for native classes.

https://codereview.chromium.org/12221162/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/lib/native_helper.dart:294: // The
code does 'obj instanceof $.Object'.  It is safer that testing a
On 2013/02/13 08:23:06, ngeoffray wrote:
> How about adding a new JS? JS_DART_OBJECT_PROTOTYPE?

Done.

[ngeoffray, 2013-02-15 13:44:02]

LGTM