Issue 12221094: Deprecate comparison operators of DateTime.

Issue 12221094: Deprecate comparison operators of DateTime. (Closed)

Created:
7 years, 10 months ago by floitsch

Modified:
7 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deprecate comparison operators of DateTime. Committed: http://code.google.com/p/dart/source/detail?r=18543

Patch Set 2 : Address comments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -9 lines)			Patch
M	sdk/lib/core/date_time.dart	View	1	1 chunk	+47 lines, -8 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/corelib/date_time_test.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/12221094/diff/1/sdk/lib/core/date_time.dart File sdk/lib/core/date_time.dart (right): https://codereview.chromium.org/12221094/diff/1/sdk/lib/core/date_time.dart#newcode301 sdk/lib/core/date_time.dart:301: * *Deprecated* Use [isAfter] instead (`!isAfter`). Don't use ...

7 years, 10 months ago (2013-02-11 13:05:20 UTC) #2

floitsch

7 years, 10 months ago (2013-02-11 21:12:16 UTC) #3

https://codereview.chromium.org/12221094/diff/1/sdk/lib/core/date_time.dart
File sdk/lib/core/date_time.dart (right):

https://codereview.chromium.org/12221094/diff/1/sdk/lib/core/date_time.dart#n...
sdk/lib/core/date_time.dart:301: * *Deprecated* Use [isAfter] instead
(`!isAfter`).
On 2013/02/11 13:05:20, Lasse Reichstein Nielsen wrote:
> Don't use backquote.
> Consider adding isNotAfter.

I prefer not to.
But we can discuss this. For now I will leave it out (always easier to add than
to remove).

https://codereview.chromium.org/12221094/diff/1/sdk/lib/core/date_time.dart#n...
sdk/lib/core/date_time.dart:346: * comparison is independent of whether the time
is utc or in the local
On 2013/02/11 13:05:20, Lasse Reichstein Nielsen wrote:
> 'is UTC' => 'is in UTC'

Done.

https://codereview.chromium.org/12221094/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/12221094/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:242: LibTest/core/Date/operator_equality_A01_t01:
Fail # DateTime.== now looks at timezone, co19 issue TODO(floitsch): issue
number
On 2013/02/11 13:05:20, Lasse Reichstein Nielsen wrote:
> Remember to add number.

Done.

Expand Messages | Collapse Messages