Issue 12221087: Add +, - and * to Duration.

Issue 12221087: Add +, - and * to Duration. (Closed)

Created:
7 years, 10 months ago by floitsch

Modified:
7 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add +, -, * and comparison operators to Duration. Committed: https://code.google.com/p/dart/source/detail?r=18296

Patch Set 2 : Add comparison operators to Duration. #

Total comments: 6

Patch Set 3 : Added ~/ operator. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -0 lines)			Patch
	M	sdk/lib/core/duration.dart	View	1 2	1 chunk	+46 lines, -0 lines	0 comments	Download
	A	tests/corelib/duration_test.dart	View	1 2	1 chunk	+167 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/12221087/diff/3001/sdk/lib/core/duration.dart File sdk/lib/core/duration.dart (right): https://codereview.chromium.org/12221087/diff/3001/sdk/lib/core/duration.dart#newcode10 sdk/lib/core/duration.dart:10: class Duration implements Comparable { We should add a ...

7 years, 10 months ago (2013-02-09 01:13:30 UTC) #3

floitsch

7 years, 10 months ago (2013-02-09 02:08:04 UTC) #5

https://codereview.chromium.org/12221087/diff/3001/sdk/lib/core/duration.dart
File sdk/lib/core/duration.dart (right):

https://codereview.chromium.org/12221087/diff/3001/sdk/lib/core/duration.dart...
sdk/lib/core/duration.dart:10: class Duration implements Comparable {
On 2013/02/09 01:13:30, Lasse Reichstein Nielsen wrote:
> We should add a type variable to Comparable, so it would be
Comparable<Duration>
> here, and compareTo method expects a Duration.

Definitely.
Filed http://dartbug.com/8445

https://codereview.chromium.org/12221087/diff/3001/sdk/lib/core/duration.dart...
sdk/lib/core/duration.dart:73: }
On 2013/02/09 01:13:30, Lasse Reichstein Nielsen wrote:
> Consider having ~/ too.

Done.

https://codereview.chromium.org/12221087/diff/3001/tests/corelib/duration_tes...
File tests/corelib/duration_test.dart (right):

https://codereview.chromium.org/12221087/diff/3001/tests/corelib/duration_tes...
tests/corelib/duration_test.dart:138: d = d1 * -1;
On 2013/02/09 01:13:30, Lasse Reichstein Nielsen wrote:
> Test "* 0" too.

Done.

Expand Messages | Collapse Messages