Issue 1221893003: performance measurement improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221893003: performance measurement improvements (Closed)

Created:
5 years, 5 months ago by danrubel

Modified:
5 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

performance measurement improvements * report mean, 90th, 99th, and std-dev * increase analysis wait time to 60 seconds * add option for analysis server localhost diagnostics * report running old vs new task model * do not check if src dir exists so that scripts are more portable * set clientRequestTime for each request * ensure dir paths have trailing separators BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d2bd01852fda2752ad7a97eb42c8b5c08c5d7716

Patch Set 1 #

Patch Set 2 : merge #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -51 lines)			Patch
M	pkg/analysis_server/test/integration/integration_tests.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/performance/driver.dart	View	7 chunks	+45 lines, -17 lines	0 comments	Download
M	pkg/analysis_server/test/performance/input_converter.dart	View	5 chunks	+18 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/test/performance/instrumentation_input_converter.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/performance/local_runner.dart	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/test/performance/log_file_input_converter.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/performance/main.dart	View	8 chunks	+44 lines, -13 lines	0 comments	Download
M	pkg/analysis_server/test/performance/operation.dart	View	5 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

5 years, 5 months ago (2015-06-30 22:08:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d2bd01852fda2752ad7a97eb42c8b5c08c5d7716 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages