Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1221823002: Tweak order of parts of lazy initializer list. (Closed)

Created:
5 years, 5 months ago by sra1
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak order of parts of lazy initializer list. Keeping all the names together rather than sandwiching the function makes it less confusing to read. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6d1b57277a317603e6311983f40aafac8afde61e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
s
5 years, 5 months ago (2015-06-30 15:43:32 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 5 months ago (2015-06-30 15:46:15 UTC) #3
sra1
5 years, 5 months ago (2015-07-01 00:32:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6d1b57277a317603e6311983f40aafac8afde61e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698