Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12218185: Separating Web SQL into dart:web_sql. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Anton Muhin
Visibility:
Public.

Description

Separating Web SQL into dart:web_sql. These APIs are essentially deprecated as standardization as ceased for them, but they are also the only DBs available for mobile devices. Separating out so it's easier to disable later. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+965 lines, -913 lines) Patch
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +6 lines, -440 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +4 lines, -462 lines 0 comments Download
A sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +450 lines, -0 lines 0 comments Download
A sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 chunk +473 lines, -0 lines 0 comments Download
M tests/html/websql_test.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 10 months ago (2013-02-20 01:19:28 UTC) #1
sra1
lgtm
7 years, 10 months ago (2013-02-20 02:03:06 UTC) #2
blois
7 years, 10 months ago (2013-02-20 21:05:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698