Issue 12218127: Revert unittest test that makes use of function names as dart2js does not support this.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218127: Revert unittest test that makes use of function names as dart2js does not support this. (Closed)

Created:
7 years, 10 months ago by gram

Modified:
7 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

TBR: Revert unittest test that makes use of function names as dart2js does not support this. Committed: https://code.google.com/p/dart/source/detail?r=18405

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	pkg/unittest/test/unittest_test.dart	View		4 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

7 years, 10 months ago (2013-02-12 22:20:40 UTC) #3

Message was sent while issue was closed.

On 2013/02/12 22:19:14, Siggi Cherem (dart-lang) wrote:
> lgtm :(

Oh, I just realized that you still print it, just not check for it in the
unittest tests. Ok, I'm happier now =)

Expand Messages | Collapse Messages