Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 12218119: Added documentation links to all of the pkg packages hosted on api.dartlang.org. (Closed)

Created:
7 years, 10 months ago by Andrei Mouravski
Modified:
7 years, 10 months ago
Reviewers:
Bob Nystrom, dgrove
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Added documentation links to all of the pkg packages hosted on api.dartlang.org. Committed: https://code.google.com/p/dart/source/detail?r=18414

Patch Set 1 #

Patch Set 2 : Changed to short link. #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/args/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/logging/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/meta/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/serialization/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/unittest/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Andrei Mouravski
The documentation links will be visible on pub once pub.dartlang.org is pushed with this feature ...
7 years, 10 months ago (2013-02-12 17:55:29 UTC) #1
dgrove
On 2013/02/12 17:55:29, Andrei Mouravski wrote: > The documentation links will be visible on pub ...
7 years, 10 months ago (2013-02-12 18:04:23 UTC) #2
Andrei Mouravski
On 2013/02/12 18:04:23, dgrove wrote: > I'd prefer to point these to redirecting links on ...
7 years, 10 months ago (2013-02-12 18:27:18 UTC) #3
Andrei Mouravski
https://code.google.com/p/dart/issues/detail?id=8501 has been fixed, so this change should be unblocked.
7 years, 10 months ago (2013-02-12 22:45:49 UTC) #4
dgrove
The URL's need to be updated per my comment. Also, we haven't been publishing fixnum ...
7 years, 10 months ago (2013-02-12 22:49:00 UTC) #5
Andrei Mouravski
PTAL. https://codereview.chromium.org/12218119/diff/4001/pkg/args/pubspec.yaml File pkg/args/pubspec.yaml (right): https://codereview.chromium.org/12218119/diff/4001/pkg/args/pubspec.yaml#newcode4 pkg/args/pubspec.yaml:4: documentation: http://api.dartlang.org/docs/args.html On 2013/02/12 22:49:00, dgrove wrote: > ...
7 years, 10 months ago (2013-02-12 23:05:32 UTC) #6
Bob Nystrom
LGTM.
7 years, 10 months ago (2013-02-12 23:23:52 UTC) #7
dgrove
7 years, 10 months ago (2013-02-15 01:25:24 UTC) #8
Message was sent while issue was closed.
On 2013/02/12 23:23:52, Bob Nystrom wrote:
> LGTM.

The URLs are actually still pointing to the wrong locations (there is no .html
at the end). I'll submit a new CL for this now.

Powered by Google App Engine
This is Rietveld 408576698