Issue 12218105: Skip flaky async window test while cause is investigated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218105: Skip flaky async window test while cause is investigated. (Closed)

Created:
7 years, 10 months ago by gram

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, blois

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Skip flaky async window test while cause is investigated. Committed: https://code.google.com/p/dart/source/detail?r=18365

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/html/html.status	View		2 chunks	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 10 months ago (2013-02-12 01:47:14 UTC) #2

lgtm with comment.
Do talk to Pete, though. Last I heard he was talking about trying to get rid of
that test because it wasn't testing things correctly, but I don't remember the
specifics.

https://codereview.chromium.org/12218105/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12218105/diff/1/tests/html/html.status#newcode31
tests/html/html.status:31: async_window_test: Pass,Fail #TODO(gram):
investigating
delete this line

Expand Messages | Collapse Messages