Issue 12218046: Add unit tests which reliabily reproduces the error condition reported in Issue 6080 without the ne…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218046: Add unit tests which reliabily reproduces the error condition reported in Issue 6080 without the ne… (Closed)

Created:
7 years, 10 months ago by siva

Modified:
7 years, 10 months ago

Reviewers:
Tom Ball, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add unit tests which reliabily reproduces the error condition reported in Issue 6080 without the need for a specialized and inconsistent private environment. Committed: https://code.google.com/p/dart/source/detail?r=18232

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+330 lines, -9 lines)			Patch
	M	tests/vm/vm.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	vm/debugger_api_impl_test.cc	View	1	7 chunks	+328 lines, -9 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://codereview.chromium.org/12218046/diff/3001/vm/debugger_api_impl_test.cc File vm/debugger_api_impl_test.cc (right): https://codereview.chromium.org/12218046/diff/3001/vm/debugger_api_impl_test.cc#newcode1252 vm/debugger_api_impl_test.cc:1252: // Frame 0 corresponding to "local_to_main". I see ...

7 years, 10 months ago (2013-02-07 17:56:51 UTC) #3

siva

7 years, 10 months ago (2013-02-07 20:33:21 UTC) #5

https://codereview.chromium.org/12218046/diff/3001/vm/debugger_api_impl_test.cc
File vm/debugger_api_impl_test.cc (right):

https://codereview.chromium.org/12218046/diff/3001/vm/debugger_api_impl_test....
vm/debugger_api_impl_test.cc:1252: // Frame 0 corresponding to "local_to_main".
Sure makes sense, we could fix it in a different CL as Tom suggests by adding a
ListContains method.

On 2013/02/07 17:56:52, hausner wrote:
> I see this is not your code, but I think it would be better to check locals
> without relying on a particular order in the list returned by the debugger.
Feel
> free to ignore this comment for this checkin.

Expand Messages | Collapse Messages