Issue 12218035: Fix socket error reporting on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12218035: Fix socket error reporting on Windows (Closed)

Created:
7 years, 10 months ago by Søren Gjesse

Modified:
7 years, 10 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix socket error reporting on Windows An error which happened during writing could be reported as error code 0 (which indicate success). This has been fixed so that the original error is reported. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18171

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -22 lines)			Patch
	M	runtime/bin/eventhandler_win.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	runtime/bin/eventhandler_win.cc	View		6 chunks	+24 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks!

Expand Messages | Collapse Messages